-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use web client to load oCIS files and spaces #201
Conversation
ae16603
to
e939827
Compare
e939827
to
f42ac96
Compare
f42ac96
to
c9b58f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good progress, thank you!
Found some issues, see comments.
web-client
seems to be initialized with the current access token and then never updated. Means once the token renewal happened the web-client
(at least for webdav I had the issue) still has the old access token and hence failing requests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not able to test the latest changes, I get a basic auth popup upon trying to load the page at https://host.docker.internal:3000
in the ocis example 🙈
@kulmann I have tried to reproduce this but hasn't been successful. After opening the URL I see the login button just fine without any basic auth... I went through the code to see if there is something that could trigger it but did not see anything. I guess we might need some debugging session together to see it happening and figure out what caused it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice job! ❤️
Thanks for also removing the uikit assets again :-)
needed to |
Refs #194