Handle the versions in the trashbin for the checksum verify command #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mrow4a
reviewed
Jul 27, 2022
|
confirmed it resolves the exception for keys of versions in trashbin 👍 |
mrow4a
approved these changes
Jul 27, 2022
jvillafanez
force-pushed
the
handle_versions_in_trashbin
branch
from
1fdfb6e to
266fab2
Compare
|
Kudos, SonarCloud Quality Gate passed! |
|
merge or something more to discuss? |
|
I created release issue #362 and put it in the qualification column of the Releases project so that someone can decide when to do a release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
files:checksum:verifywas failing due to problems finding the right key with the versions that were in the trashbin. This was caused by a wrong computation for the right path where the key is.Rel https://github.com/owncloud/enterprise/issues/5272