Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust text of occ encryption command messages #39395

Merged
merged 1 commit into from
Oct 22, 2021
Merged

Adjust text of occ encryption command messages #39395

merged 1 commit into from
Oct 22, 2021

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Oct 22, 2021 •
edited
Loading

Description

When reviewing PR #39217 I noticed a few improvements that could be made to the messages in occ encryption commands. These are the changes.

Mote: these occ command texts are not translated. So these changes won't cause a hassle in Transifex.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis self-assigned this Oct 22, 2021
@phil-davis phil-davis force-pushed the text-of-encryption-commands branch from ffef2e6 to 924f7b8 Compare October 22, 2021 08:47
@owncloud owncloud deleted a comment from update-docs bot Oct 22, 2021
@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiShareOperationsToRoot1-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33267/67/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiShareCreateSpecialToShares2-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33267/61/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiProvisioning-v2-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33267/55/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiVersions-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33267/85/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline cliLocalStorage-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33267/115/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiSharingNotificationsToShares-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/33267/101/1

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
25.0% 25.0% Duplication

JammingBen
JammingBen approved these changes Oct 22, 2021
View reviewed changes
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@phil-davis phil-davis merged commit e871c2a into master Oct 22, 2021
@delete-merged-branch delete-merged-branch bot deleted the text-of-encryption-commands branch October 22, 2021 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

@pmaier1 pmaier1 Awaiting requested review from pmaier1

@micbar micbar Awaiting requested review from micbar

@AlexAndBear AlexAndBear Awaiting requested review from AlexAndBear

@IljaN IljaN Awaiting requested review from IljaN

Assignees

@phil-davis phil-davis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phil-davis @ownclouders @JammingBen