[tests-only]TUS tests for chunking with checksum #38471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
swoichha
requested review from
Talank,
jasson99,
kiranparajuli589,
dpakach and
haribhandari07
Talank
reviewed
Mar 5, 2021
swoichha
force-pushed
the
tusTests-checksum-chunking
branch
from
540fc49
to
33da250
Compare
swoichha
force-pushed
the
tusTests-checksum-chunking
branch
from
86bd9ee
to
c1aa12c
Compare
individual-it
approved these changes
Mar 9, 2021
|
please make sure commit id and expected to fail files are updated in ocis and cs3org/reva |
|
Kudos, SonarCloud Quality Gate passed!
|
| @@ -161,6 +163,13 @@ public function userUploadsUsingTusAFileTo( | |||
| ]; | |||
| $headers = \array_merge($headers, $creationWithUploadHeader); | |||
| } | |||
| if ($checksum != '') { | |||
There was a problem hiding this comment.
Suggested change
| if ($checksum != '') { | |
| if (!$checksum) { |
| @@ -147,7 +148,8 @@ public function userUploadsUsingTusAFileTo( | |||
| string $destination, | |||
| array $uploadMetadata = [], | |||
| int $noOfChunks = 1, | |||
| int $bytes = null | |||
| int $bytes = null, | |||
| string $checksum = '' | |||
There was a problem hiding this comment.
Suggested change
| string $checksum = '' | |
| string $checksum = null |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds test for TUS chunking with checksum.
Related Issue
How Has This Been Tested?
Types of changes
Checklist: