-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tests-Only] ideas for a tool to make BDD for OCIS using oc10 API tests easier #37432
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
||
Scenario: create new PRs | ||
Given the user has checked out the branch "changed-tests" | ||
When the user runs the command "crate-prs" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the user runs the command "crate-prs" | |
When the user runs the command "create-prs" |
Given the user has checked out the branch "changed-tests" | ||
And an open PR to the "ocis" repo exists with the core branch "changed-tests" as test-runner | ||
And an open PR to the "ocis-reva" repo exists with the core branch "changed-tests" as test-runner | ||
When the user runs the command "crate-prs" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the user runs the command "crate-prs" | |
When the user runs the command "create-prs" |
Scenario Outline: create new PRs with bugfix changes | ||
Given the user has checked out the branch "changed-tests" | ||
And the user has checked out the branch "bug-fix" of the "<repo-with-changes>" local clone | ||
When the user runs the command "crate-prs --<repo-with-changes>=%path-to-<repo-with-changes>-clone%" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the user runs the command "crate-prs --<repo-with-changes>=%path-to-<repo-with-changes>-clone%" | |
When the user runs the command "create-prs --<repo-with-changes>=%path-to-<repo-with-changes>-clone%" |
Codecov Report
@@ Coverage Diff @@
## master #37432 +/- ##
=========================================
Coverage 64.61% 64.61%
Complexity 19254 19254
=========================================
Files 1270 1270
Lines 75262 75262
Branches 1331 1331
=========================================
Hits 48628 48628
Misses 26242 26242
Partials 392 392
Continue to review full report at Codecov.
|
somehow with all the recent happenings I wonder if we should use git submodules or use the commit hash in the git clone command in Drone to run tests on a specific version of the tests this would provide reproducible test runs, because now often times when tests were passing in one build it fails in another because owncloud/core was changed: owncloud/ocis-reva#215 (comment) |
Pls rename the PR and add a leading |
Thanks @mmattel ! |
this is not needed anymore see discussion in https://jira.owncloud.com/browse/OCIS-217 |
ideas for a tool that would make the multi-stage BDD process described in https://owncloud.github.io/extensions/ocis_reva/testing/ simpler.
@jnweiger @C0rby @kulmann @phil-davis @dpakach @jnweiger @LukasHirt @refs @PVince81 would a tool described in the feature files be helpful? Or what would be helpful to make your live easier with the API tests and the juggling of the multiple repos?