Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] ideas for a tool to make BDD for OCIS using oc10 API tests easier #37432

Closed
wants to merge 1 commit into from

Conversation

individual-it
Copy link
Member

ideas for a tool that would make the multi-stage BDD process described in https://owncloud.github.io/extensions/ocis_reva/testing/ simpler.

@jnweiger @C0rby @kulmann @phil-davis @dpakach @jnweiger @LukasHirt @refs @PVince81 would a tool described in the feature files be helpful? Or what would be helpful to make your live easier with the API tests and the juggling of the multiple repos?

@update-docs
Copy link

update-docs bot commented May 22, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.


Scenario: create new PRs
Given the user has checked out the branch "changed-tests"
When the user runs the command "crate-prs"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When the user runs the command "crate-prs"
When the user runs the command "create-prs"

Given the user has checked out the branch "changed-tests"
And an open PR to the "ocis" repo exists with the core branch "changed-tests" as test-runner
And an open PR to the "ocis-reva" repo exists with the core branch "changed-tests" as test-runner
When the user runs the command "crate-prs"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When the user runs the command "crate-prs"
When the user runs the command "create-prs"

Scenario Outline: create new PRs with bugfix changes
Given the user has checked out the branch "changed-tests"
And the user has checked out the branch "bug-fix" of the "<repo-with-changes>" local clone
When the user runs the command "crate-prs --<repo-with-changes>=%path-to-<repo-with-changes>-clone%"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When the user runs the command "crate-prs --<repo-with-changes>=%path-to-<repo-with-changes>-clone%"
When the user runs the command "create-prs --<repo-with-changes>=%path-to-<repo-with-changes>-clone%"

@codecov
Copy link

codecov bot commented May 22, 2020

Codecov Report

Merging #37432 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37432   +/-   ##
=========================================
  Coverage     64.61%   64.61%           
  Complexity    19254    19254           
=========================================
  Files          1270     1270           
  Lines         75262    75262           
  Branches       1331     1331           
=========================================
  Hits          48628    48628           
  Misses        26242    26242           
  Partials        392      392           
Flag Coverage Δ Complexity Δ
#javascript 54.14% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.77% <ø> (ø) 19254.00 <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0569d39...59524ea. Read the comment docs.

@PVince81
Copy link
Contributor

somehow with all the recent happenings I wonder if we should use git submodules or use the commit hash in the git clone command in Drone to run tests on a specific version of the tests

this would provide reproducible test runs, because now often times when tests were passing in one build it fails in another because owncloud/core was changed: owncloud/ocis-reva#215 (comment)

@mmattel
Copy link
Contributor

mmattel commented May 22, 2020

Pls rename the PR and add a leading [Tests-Only] as it targets tests.
For reference, see all the other test PRs.

@refs refs changed the title ideas for a tool to make BDD for OCIS using oc10 API tests easier [Tests-Only] ideas for a tool to make BDD for OCIS using oc10 API tests easier Jun 8, 2020
@refs
Copy link
Member

refs commented Jun 8, 2020

Pls rename the PR and add a leading [Tests-Only] as it targets tests.
For reference, see all the other test PRs.

Thanks @mmattel !

@individual-it
Copy link
Member Author

this is not needed anymore see discussion in https://jira.owncloud.com/browse/OCIS-217
an other way to simplify test runs was implemented see #37717

@individual-it individual-it deleted the bddtoolsforocis branch August 13, 2020 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants