-
Notifications
You must be signed in to change notification settings - Fork 3.1k
[FIX] Image autoupload uploads images twice under certain conditions #4571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Good job @JuancaG05 💯 Let's see if it works.
NOTE: Don't forget to add calens file and release note if this PR is going to be merged into master
branch.
(1) [FIXED]
Current: No folder is chosen, therefore no pictures are uploaded Expected: Folder chosen is set as subtitle and uploads work Pixel 7 |
(2) [FIXED]
Current: The list of spaces is the one of the first account (the one selected in step 3.) Expected: The list of spaces is the one of the second account (the one selected in step 4.) Pixel 7 |
87e6bce
to
c9139c8
Compare
@jesmrec (1) and (2) should be fixed now |
(3)After some tests, i got some duplications... this is the log if it helps somehow: owncloud.2025-04-16_08.41.04.log Samsung A8 |
@jesmrec regarding (3), those duplicates seen in logs refer to 0B files... let's see at least if worker flow is correct now (timestamp taken is correct, as seen in those logs) and maybe we can address the 0B problem in a separate issue |
Related Issues
App: #3983
ReleaseNotesViewModel.kt
creating a newReleaseNote()
with String resources (if required)QA