Skip to content

[FIX] Image autoupload uploads images twice under certain conditions #4571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

JuancaG05
Copy link
Collaborator

@JuancaG05 JuancaG05 commented Apr 14, 2025

Related Issues

App: #3983

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

@JuancaG05 JuancaG05 requested a review from joragua April 14, 2025 07:57
@JuancaG05 JuancaG05 self-assigned this Apr 14, 2025
Copy link
Collaborator

@joragua joragua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good job @JuancaG05 💯 Let's see if it works.

NOTE: Don't forget to add calens file and release note if this PR is going to be merged into master branch.

@jesmrec
Copy link
Collaborator

jesmrec commented Apr 15, 2025

(1) [FIXED]

  1. Install the app from scratch
  2. Add an account
  3. Enable auto uploads for pictures
  4. Choose the Camera folder (required) and submit

Current:

No folder is chosen, therefore no pictures are uploaded

Expected:

Folder chosen is set as subtitle and uploads work

Pixel 7
Xiaomi Redmi 13
Samsung A8
87e6bcec0

@jesmrec
Copy link
Collaborator

jesmrec commented Apr 15, 2025

(2) [FIXED]

  1. Add two accounts to the device
  2. Enable Automatic Picture uploads
  3. Select one of them as Account to upload pictures and an upload path
  4. Then, click on Account to upload pictures and select the other account
  5. Click on Picture upload path

Current:

The list of spaces is the one of the first account (the one selected in step 3.)

Expected:

The list of spaces is the one of the second account (the one selected in step 4.)

Pixel 7
Xiaomi Redmi 13
Samsung A8
87e6bcec0

@JuancaG05 JuancaG05 force-pushed the fix/duplicated_autouploads branch from 87e6bce to c9139c8 Compare April 15, 2025 15:54
@JuancaG05
Copy link
Collaborator Author

@jesmrec (1) and (2) should be fixed now

@jesmrec
Copy link
Collaborator

jesmrec commented Apr 16, 2025

(3)

After some tests, i got some duplications... this is the log if it helps somehow:

owncloud.2025-04-16_08.41.04.log

Samsung A8

@JuancaG05
Copy link
Collaborator Author

JuancaG05 commented Apr 21, 2025

@jesmrec regarding (3), those duplicates seen in logs refer to 0B files... let's see at least if worker flow is correct now (timestamp taken is correct, as seen in those logs) and maybe we can address the 0B problem in a separate issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Image autoupload uploads images twice under certain conditions
4 participants