-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support JS Restify #273
Support JS Restify #273
Conversation
@ksg97031
|
Done ! @hahwul :) thanks |
./bin/noir -b ./spec/functional_test/fixtures/js_restify/
# GET /?name=
# ○ headers: X-API-Key:
# POST /upload
# ○ cookies: auth=
# ○ body: {"name":""}
crystal spec
# Finished in 17.83 milliseconds
# 822 examples, 0 failures, 0 errors, 0 pending
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Gby56
Hey there!
First off, thanks so much for your patience, especially given my recent break—it really means a lot. The code is clean, well-organized, and just what we need. I'm all set to merge this!
We're aiming to roll this out by next month's release. If anything else pops up or if you have more cool ideas, don’t hesitate to kick off another PR.
Thanks again—you’re awesome!
Turns out it's pretty much the same thing as Express for now, we can keep it separate if the frameworks are slightly different !
Fixes #272