Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Common URL processing logic #188

Merged
merged 8 commits into from
Dec 11, 2023
Merged

Implement Common URL processing logic #188

merged 8 commits into from
Dec 11, 2023

Conversation

hahwul
Copy link
Member

@hahwul hahwul commented Dec 9, 2023 •
edited
Loading

@ksg97031
I add the common logic for URL processing(combine_url_and_endpoints in noir model). There have been some changes in the Analyzer code, and there were no significant issues during testing. Please review at your convenience. :D

@hahwul hahwul added this to the vNext milestone Dec 9, 2023
@hahwul hahwul requested a review from ksg97031 December 9, 2023 14:54
@hahwul hahwul self-assigned this Dec 9, 2023
@hahwul hahwul removed this from the vNext milestone Dec 9, 2023
@hahwul
Copy link
Member Author

hahwul commented Dec 9, 2023

Issue: #184

@hahwul hahwul changed the title Implement Common URL Handling Logic (from #184) Implement Common URL processing logic Dec 9, 2023
@hahwul hahwul added this to the v0.12.0 milestone Dec 10, 2023
ksg97031
ksg97031 approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@ksg97031 ksg97031 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've appended a commit to refactor the combine_url_endpoints method!

@ksg97031 ksg97031 merged commit 067881d into dev Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksg97031 ksg97031 ksg97031 approved these changes

Assignees

@hahwul hahwul

Labels
None yet
Projects
None yet
Milestone
v0.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@hahwul @ksg97031