Add resource & data source instance #696

Tiboau · 2024-07-26T13:09:08Z

Description

Add resource and datasource for instance(s)

Type of change

Please delete options that are not relevant.

New feature (non-breaking change which adds functionality)
Documentation update

How Has This Been Tested?

export OVH_CLOUD_PROJECT_SERVICE_TEST="AAA"
export OVH_CLOUD_PROJECT_REGION_TEST="XXX"
export OVH_CLOUD_PROJECT_IMAGE_ID_TEST="YYYY"
export OVH_CLOUD_PROJECT_FLAVOR_ID_TEST="ZZZZZ"
export OVH_CLOUD_PROJECT_SSH_NAME_TEST="UUUUU"

➜  terraform-provider-ovh git:(resource_cloud_project_instance.go) make testacc TESTARGS="-run TestAccCloudProjectInstance_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccCloudProjectInstance_basic -timeout 600m -p 10
?       github.com/ovh/terraform-provider-ovh   [no test files]
?       github.com/ovh/terraform-provider-ovh/ovh/helpers       [no test files]
?       github.com/ovh/terraform-provider-ovh/ovh/types [no test files]
=== RUN   TestAccCloudProjectInstance_basic
    provider_test.go:398: Read Cloud Project /cloud/project/bad3308a4b4d4dcba4d15d5b082d7225 -> status: 'ok', desc: 'Production'
--- PASS: TestAccCloudProjectInstance_basic (55.30s)
PASS
ok      github.com/ovh/terraform-provider-ovh/ovh       55.310s
testing: warning: no tests to run
PASS
ok      github.com/ovh/terraform-provider-ovh/ovh/helpers/hashcode      (cached) [no tests to run]

export OVH_CLOUD_PROJECT_SERVICE_TEST="AAA"
export OVH_CLOUD_PROJECT_REGION_TEST="XXX"
➜  terraform-provider-ovh git:(resource_cloud_project_instance.go) make testacc TESTARGS="-run TestAccDataSourceCloudProjecInstances_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccDataSourceCloudProjecInstances_basic -timeout 600m -p 10
?       github.com/ovh/terraform-provider-ovh   [no test files]
?       github.com/ovh/terraform-provider-ovh/ovh/helpers       [no test files]
?       github.com/ovh/terraform-provider-ovh/ovh/types [no test files]
=== RUN   TestAccDataSourceCloudProjecInstances_basic
    provider_test.go:398: Read Cloud Project /cloud/project/bad3308a4b4d4dcba4d15d5b082d7225 -> status: 'ok', desc: 'Production'
--- PASS: TestAccDataSourceCloudProjecInstances_basic (6.78s)
PASS
ok      github.com/ovh/terraform-provider-ovh/ovh       6.788s
testing: warning: no tests to run
PASS
ok      github.com/ovh/terraform-provider-ovh/ovh/helpers/hashcode      (cached) [no tests to run]

export OVH_CLOUD_PROJECT_SERVICE_TEST="AAA"
export OVH_CLOUD_PROJECT_REGION_TEST="XXX"
export OVH_CLOUD_PROJECT_INSTANCE_TEST="YYYY"
➜  terraform-provider-ovh git:(resource_cloud_project_instance.go) make testacc TESTARGS="-run TestAccDataSourceCloudProjecInstances_basic"
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccDataSourceCloudProjecInstancesbasic -timeout 600m -p 10
?       github.com/ovh/terraform-provider-ovh   [no test files]
?       github.com/ovh/terraform-provider-ovh/ovh/helpers       [no test files]
?       github.com/ovh/terraform-provider-ovh/ovh/types [no test files]
testing: warning: no tests to run
PASS
ok      github.com/ovh/terraform-provider-ovh/ovh       0.011s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/ovh/terraform-provider-ovh/ovh/helpers/hashcode      0.003s [no tests to run]

Test Configuration:

Terraform version: terraform version: Terraform vx.y.z
Existing HCL configuration you used:

resource "ovh_cloud_project_instance" "instance" {
    region = "BHS5"
    billing_period = "hourly"
    boot_from {
        image_id = "7ec6515e-b390-41f8-a26a-cca7e223ca2d"
    }
    flavor {
        flavor_id = "ac6f8199-3595-446f-bfc7-c80cdfcf9cbe"
    }
    name = "haproxy"
    ssh_key {
        name = "ovh_cloud"
    }
    network {
        public = true
    }   
}

data "ovh_cloud_project_instances" "instances" {
   region = ovh_cloud_project_instance.instance.region
}

data "ovh_cloud_project_instance" "desc" {
   region = ovh_cloud_project_instance.instance.region
   instance_id = ovh_cloud_project_instance.instance.id
}

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings or issues
I have added acceptance tests that prove my fix is effective or that my feature works
New and existing acceptance tests pass locally with my changes
I ran succesfully go mod vendor if I added or modify go.mod file

amstuta · 2024-07-29T10:11:19Z

ovh/data_cloud_project_instance.go

+				Type:        schema.TypeString,
+				Description: "Instance id",
+				Required:    true,
+				ForceNew:    true,


I guess ForceNew's are not really needed here

amstuta · 2024-07-29T10:12:01Z

ovh/data_cloud_project_instance.go

+			},
+			// computed
+			"addresses": {
+				Type:        schema.TypeList,


Suggested change

Type: schema.TypeList,

Type: schema.TypeSet,

no ?

amstuta · 2024-07-29T10:12:26Z

ovh/data_cloud_project_instance.go

+				Description: " Volumes attached to the instance",
+				Elem: &schema.Resource{
+					Schema: map[string]*schema.Schema{
+						"ip": {


Suggested change

"ip": {

"id": {

amstuta · 2024-07-29T10:12:43Z

ovh/data_cloud_project_instance.go

+				},
+			},
+			"attached_volumes": {
+				Type:        schema.TypeList,


Suggested change

Type: schema.TypeList,

Type: schema.TypeSet,

amstuta · 2024-07-29T10:13:39Z

ovh/data_cloud_project_instance.go

+	serviceName := d.Get("service_name").(string)
+	region := d.Get("region").(string)
+	instanceId := d.Get("instance_id").(string)
+	log.Printf("[DEBUG] SCROUTCH")


Suggested change

log.Printf("[DEBUG] SCROUTCH")

amstuta · 2024-07-29T14:09:24Z

ovh/resource_cloud_project_instance.go

+	d.Set("region", r.Region)
+	d.Set("task_state", r.TaskState)
+	d.Set("name", d.Get("name").(string))
+	//	d.Set("name", r.Name)


Suggested change

// d.Set("name", r.Name)

amstuta · 2024-07-29T14:11:02Z

ovh/resource_cloud_project_instance_test.go

+		Steps: []resource.TestStep{
+			{
+				Config: testCreateLoadBalancerLogSubscription,
+				Check: resource.ComposeTestCheckFunc(


please check values of several field

amstuta · 2024-07-29T14:12:50Z

website/docs/d/cloud_project_instances.markdown

+
+## Example Usage
+
+To get information of an instance:


Suggested change

To get information of an instance:

To list your instances:

amstuta · 2024-07-29T14:13:04Z

website/docs/d/cloud_project_instances.markdown

+
+# ovh_cloud_project_instance
+**This datasource uses a Beta API**
+Use this data source to get the list instance in a region of a public cloud project.


Suggested change

Use this data source to get the list instance in a region of a public cloud project.

Use this data source to get the list of instance in a region of a public cloud project.

amstuta · 2024-07-29T14:13:36Z

website/docs/d/cloud_project_instances.markdown

+
+The following arguments are supported:
+
+* `service_name` - (Required, Forces new resource) The id of the public cloud project. If omitted,


Suggested change

* `service_name` - (Required, Forces new resource) The id of the public cloud project. If omitted,

* `service_name` - (Required) The id of the public cloud project. If omitted,

not sure this makes sense in a datasource

create instance

ada25ad

Tiboau requested review from rbeuque74, deathiop, a-beudin, amstuta, mxpetit, yomovh and marie-j as code owners July 26, 2024 13:09

amstuta requested changes Jul 29, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add resource & data source instance #696

Add resource & data source instance #696

Tiboau commented Jul 26, 2024

amstuta Jul 29, 2024

amstuta Jul 29, 2024

amstuta Jul 29, 2024

amstuta Jul 29, 2024

amstuta Jul 29, 2024

amstuta Jul 29, 2024

amstuta Jul 29, 2024

amstuta Jul 29, 2024

amstuta Jul 29, 2024

amstuta Jul 29, 2024

	Use this data source to get the list instance in a region of a public cloud project.
	Use this data source to get the list of instance in a region of a public cloud project.


		The following arguments are supported:

		* `service_name` - (Required, Forces new resource) The id of the public cloud project. If omitted,

	* `service_name` - (Required, Forces new resource) The id of the public cloud project. If omitted,
	* `service_name` - (Required) The id of the public cloud project. If omitted,

Add resource & data source instance #696

Are you sure you want to change the base?

Add resource & data source instance #696

Conversation

Tiboau commented Jul 26, 2024

Description

Type of change

How Has This Been Tested?

Checklist:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment