Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pci-kubernetes): es translations #13166

Closed
wants to merge 1 commit into from
Closed

Conversation

frenautvh
Copy link
Contributor

Question Answer
Branch? master
Bug fix? yes
New feature? no
Breaking change? no
Tickets DTCORE-2616
License BSD 3-Clause

Description

fix malformed es translation file

ref: DTCORE-2616
Signed-off-by: Florian Renaut <[email protected]>
@frenautvh frenautvh requested a review from a team as a code owner September 19, 2024 08:57
@github-actions github-actions bot added the bug Something isn't working label Sep 19, 2024
kqesar
kqesar previously approved these changes Sep 19, 2024
sidlynx
sidlynx previously approved these changes Sep 19, 2024
@frenautvh frenautvh dismissed stale reviews from sidlynx and kqesar via 1c5bfb3 September 19, 2024 09:39
@frenautvh frenautvh requested a review from a team as a code owner September 19, 2024 09:39
kqesar
kqesar previously approved these changes Sep 19, 2024
sidlynx
sidlynx previously approved these changes Sep 19, 2024
Copy link

sonarcloud bot commented Sep 19, 2024

Copy link
Contributor

@anooparveti anooparveti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The missing comma has been added on the master branch as part of resolving conflicts https://github.com/ovh/manager/blob/master/packages/manager/apps/pci-kubernetes/public/translations/add/Messages_es_ES.json.

You can ignore this PR I guess. However i am not sure why the diff is not updated.

@frenautvh
Copy link
Contributor Author

already has been updated on master branch

@frenautvh frenautvh closed this Sep 20, 2024
@frenautvh frenautvh deleted the fix/DTCORE-2616 branch November 8, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants