Skip to content

fix bin/up with mongo change #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

darvid7
Copy link

@darvid7 darvid7 commented Apr 14, 2025

Description

fix bin/up setup

with #270 the prefix of the configuration shouldn't be in the return value.

On a new checkout I ran into

---------------------  ERROR  -----------------------
  Invalid MONGO_VERSION: MONGO_VERSION=6.0

  MONGO_VERSION must start with the actual major version of mongo, followed by a dot.
  Example: MONGO_IMAGE=my.dockerhub.com/custom-mongo
           MONGO_VERSION=6.0-custom
---------------------  ERROR  -----------------------

removing \1 fixed it.

Related issues / Pull Requests

Contributor Agreement

with overleaf#270 the prefix of the configuration shouldn't be in the return value.

On a new checkout I ran into 
 
```
---------------------  ERROR  -----------------------
  Invalid MONGO_VERSION: MONGO_VERSION=6.0

  MONGO_VERSION must start with the actual major version of mongo, followed by a dot.
  Example: MONGO_IMAGE=my.dockerhub.com/custom-mongo
           MONGO_VERSION=6.0-custom
---------------------  ERROR  -----------------------
```

removing `\1` fixed it.
@darvid7
Copy link
Author

darvid7 commented Apr 14, 2025

@mserranom can I borrow your eyes on this? I think #270 changed the mongo config and the prefix shouldn't be returned by read_configuration

@mserranom
Copy link
Contributor

Thanks @darvid7, would you mind posting the steps to reproduce, including the problematic inputs and their outputs vs the expected outputs?

@darvid7
Copy link
Author

darvid7 commented Apr 14, 2025

For sure! this is how I ran into the issue

 dlei@dlei-macbookpro3  ~/Desktop/tmp  git clone https://github.com/overleaf/toolkit.git ./overleaf-toolkit

Cloning into './overleaf-toolkit'...
remote: Enumerating objects: 2343, done.
remote: Counting objects: 100% (950/950), done.
remote: Compressing objects: 100% (204/204), done.
remote: Total 2343 (delta 844), reused 747 (delta 745), pack-reused 1393 (from 3)
Receiving objects: 100% (2343/2343), 863.22 KiB | 5.05 MiB/s, done.
Resolving deltas: 100% (1531/1531), done.
 dlei@dlei-macbookpro3  ~/Desktop/tmp  ls
overleaf-toolkit
 dlei@dlei-macbookpro3  ~/Desktop/tmp  cd overleaf-toolkit 
 dlei@dlei-macbookpro3  ~/Desktop/tmp/overleaf-toolkit   master  ls
bin          CHANGELOG.md config       data         doc          lib          LICENSE      README.md
 ✘ dlei@dlei-macbookpro3  ~/Desktop/tmp/overleaf-toolkit   master  bin/init
Copying config files to 'config/'
 dlei@dlei-macbookpro3  ~/Desktop/tmp/overleaf-toolkit   master  bin/up
---------------------  ERROR  -----------------------
  Invalid MONGO_VERSION: MONGO_VERSION=6.0

  MONGO_VERSION must start with the actual major version of mongo, followed by a dot.
  Example: MONGO_IMAGE=my.dockerhub.com/custom-mongo
           MONGO_VERSION=6.0-custom
---------------------  ERROR  -----------------------
 ✘ dlei@dlei-macbookpro3  ~/Desktop/tmp/overleaf-toolkit   master  

I was following the steps in https://github.com/overleaf/toolkit/blob/master/doc/quick-start-guide.md

With the removal of \1 the bin/up command worked (after creating data dirs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants