Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove version in the docker compose file #232

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Milokita
Copy link

Description

remove version in the docker compose file

Related issues / Pull Requests

latest docker would report, this PR address this warning

"WARN[0000] overleaf-toolkit/lib/docker-compose.base.yml: `version` is obsolete"

Contributor Agreement

@ThexXTURBOXx
Copy link

This fix would still be much appreciated, I think. Is anyone able to approve and merge this?
This will also simplify the creation of a docker compose override slightly.

@das7pad
Copy link
Member

das7pad commented Jul 17, 2024

Thanks for the suggestion @Milokita!

This is currently blocked as we still need to support docker-compose v1 in the Toolkit and removing the version field changes the behavior of docker-compose v1/breaks setups.

As noted in the release notes for Server Pro 5.1, we are planning to drop support for docker-compose v1 with the next release. At this point we can adopt this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants