Enable Authentication for Elasticsearch #1061
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nihxdr Hi. Can you add more context for this change? How will it effect the existing installations? |
regisb
reviewed
Jun 4, 2024
| @@ -39,6 +39,9 @@ | |||
| {% if ELASTICSEARCH_SCHEME == "https" %}"use_ssl": True,{% endif %} | |||
| "host": "{{ ELASTICSEARCH_HOST }}", | |||
| "port": {{ ELASTICSEARCH_PORT }}, | |||
| {% if ELASTICSEARCH_USER != '' and ELASTICSEARCH_PASSWORD != '' %} | |||
| "http_auth": ("{{ ELASTICSEARCH_USER}}", "{{ ELASTICSEARCH_PASSWORD }}"), | |||
There was a problem hiding this comment.
If we start supporting http auth in Elasticsearch, then we will have also to update all tutor plugins that connect to Elasticsearch (including forum). This is going to be non-trivial.
|
With Elasticsearch going to replace with meilisearch in Sumac #1141, I don't think this is needed anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces user authentication for Elasticsearch, enhancing our Open edX instance's connectivity with external Elasticsearch services that require authentication.