fix: do not fail on start when there are no persistent volume claims

Persistent volume claims are being created alongside with other objects to acheive that.
overhangio · Jun 25, 2024 · c8ce86b · c8ce86b
1 parent c4fd306
commit c8ce86b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 9 deletions.
diff --git a/changelog.d/20240619_122432_illia_k8s_no_volumes_no_fail.md b/changelog.d/20240619_122432_illia_k8s_no_volumes_no_fail.md
@@ -0,0 +1 @@
+[Bugfix] Do not fail on start when there are not persistent volume claims to apply (by @snglth)
diff --git a/tutor/commands/k8s.py b/tutor/commands/k8s.py
@@ -296,18 +296,11 @@ def start(context: K8sContext, names: List[str]) -> None:
     names = names or ["all"]
     for name in names:
         if name == "all":
-            # Create volumes
+            # Create everything except jobs
             kubectl_apply(
                 context.root,
-                "--wait",
                 "--selector",
-                "app.kubernetes.io/component=volume",
-            )
-            # Create everything else except jobs
-            kubectl_apply(
-                context.root,
-                "--selector",
-                "app.kubernetes.io/component notin (job,volume,namespace)",
+                "app.kubernetes.io/component notin (job,namespace)",
             )
         else:
             kubectl_apply(