fix: docker build deprecation warnings

With the latest Docker upgrade, we got the following warnings during build: FromAsCasing: 'as' and 'FROM' keywords' casing do not match LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
overhangio · Jun 21, 2024 · 9671824 · 9671824
1 parent 06fd645
commit 9671824
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/changelog.d/20240621_170044_regis.md b/changelog.d/20240621_170044_regis.md
@@ -0,0 +1 @@
+- [Bugfix] Fix legacy warnings during Docker build. (by @regisb)
diff --git a/tutornotes/templates/notes/build/notes/Dockerfile b/tutornotes/templates/notes/build/notes/Dockerfile
@@ -15,7 +15,7 @@ RUN --mount=type=cache,target=/var/cache/apt,sharing=locked \
     pkg-config && \
   sed -i '/en_US.UTF-8/s/^# //g' /etc/locale.gen && \
   locale-gen
-ENV LC_ALL en_US.UTF-8
+ENV LC_ALL=en_US.UTF-8
 
 ###### Git-clone Notes repo ######
 ARG APP_USER_ID=1000
@@ -27,7 +27,7 @@ WORKDIR /app/edx-notes-api
 
 ###### Install python venv ######
 RUN python -m venv /app/venv
-ENV PATH /app/venv/bin:${PATH}
+ENV PATH=/app/venv/bin:${PATH}
 # https://pypi.org/project/setuptools/
 # https://pypi.org/project/pip/
 # https://pypi.org/project/wheel/