Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add learner record MFE to plugin #63

Closed
wants to merge 2 commits into from
Closed

feat: add learner record MFE to plugin #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb80bc3
feat: add learner record MFE to plugin
Tj-Tracy Oct 11, 2022
603b468
chore: add to readme
Tj-Tracy Oct 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ In addition, this plugin comes with a few MFEs which are enabled by default:
- `Gradebook <https://github.com/edx/frontend-app-gradebook/>`__
- `Learning <https://github.com/edx/frontend-app-learning/>`__
- `Profile <https://github.com/edx/frontend-app-profile/>`__
- `Learner Records <https://github.com/edx/frontend-app-learner-record/>`__

Instructions for using each of these MFEs are given below.

Expand Down
11 changes: 11 additions & 0 deletions tutormfe/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,17 @@
},
},
},
"RECORDS_MFE_APP": {
"name": "records",
"repository": "https://github.com/openedx/frontend-app-learner-record",
"port": 1990,
"env": {
"production": {
"SUPPORT_URL_LEARNER_RECORDS":"",
"USE_LR_MFE": "",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a good reason why these settings do not have these values as default upstream?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the first settings currently only has an edX-specific default, and the second one is for a feature that currently unsupported in tutor. Would it be a better idea to just leave them out? the MFE still operates if they are not present.

Copy link
Contributor

@regisb regisb Oct 21, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the first settings currently only has an edX-specific default

Can we change the upstream default such that it works out of the box for everyone instead of just edX?

Would it be a better idea to just leave them out?

Not if they are needed for some features, no.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FTR, it was decided in a BTR meeting that instead of adding the learner-records MFE to Tutor (and thus enabling it by default for everyone) there would be instructions on how to enable it, either here in the tutor-mfe README, or in the learner-records MFE README.

},
},
},
},
}

Expand Down