Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: an honest deprecation warning for ecommerce service #82

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

sarina
Copy link
Contributor

@sarina sarina commented Jul 12, 2024

Add the warning on the ecommerce repo to the Tutor plugin - see https://github.com/openedx/ecommerce?tab=readme-ov-file#%EF%B8%8F-warning

Partially addresses openedx/docs.openedx.org#525 - see that ticket for more detail/discussion.

Add the warning on the ecommerce repo to the Tutor plugin
README.rst Outdated
Comment on lines 9 to 10
This service is under-maintained. We are not fixing bugs or developing new features for it. We hope to deprecate and replace it soon. For updates, `follow along on the DEPR ticket <https://github.com/openedx/public-engineering/issues/22>`_.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Instead of "This service", "We", the wording should be renamed to signify:

  • This service --> e-commerce and e-commerce worker
  • We --> Axim

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree on the first point, but I feel "we" is the entire Open edX community, not just Axim.

@DawoudSheraz DawoudSheraz requested a review from regisb July 15, 2024 11:38
README.rst Outdated Show resolved Hide resolved
@DawoudSheraz DawoudSheraz merged commit d901edb into overhangio:master Jul 15, 2024
2 checks passed
@sarina sarina deleted the patch-1 branch July 15, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants