feat: change image CMD to celery v5 compatibility in ecom worker #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a proposal in order to allow ecommerce-worker increase celery to v5.4.0 This upgrade of celery in the following PR: openedx-unsupported/ecommerce-worker#247
|
Closed In favour of : |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a proposal in order to allow ecommerce-worker increase celery to v5.4.0
This upgrade of celery is in the following PR: openedx-unsupported/ecommerce-worker#247
Before
I tried to use the update code related in celery and I found some incompatibilities.
For more details you could check the following PR:
openedx-unsupported/ecommerce-worker#247 (comment)
V5.4.0 the celery command doesn't start.
After
Celery worker in V5.4.0 Seems working
I also test the args change with celery v4.4.7 but I prefer that this be tested with care.
This to think when this PR would be merged: before or after openedx-unsupported/ecommerce-worker#247