Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade dockerfiles to be compatible with python 3.8.0 to 3.12.2 #72

Merged

Conversation

Faraz32123
Copy link
Collaborator

@Faraz32123 Faraz32123 commented Mar 18, 2024

close #68

@Faraz32123 Faraz32123 self-assigned this Mar 18, 2024
@Faraz32123 Faraz32123 marked this pull request as draft March 18, 2024 12:03
@Faraz32123 Faraz32123 marked this pull request as ready for review March 19, 2024 10:16
@DawoudSheraz DawoudSheraz self-requested a review March 26, 2024 09:26
 => [minimal  7/19] RUN echo "{}" > /openedx/config.yml                                                                          0.2s
 => ERROR [minimal  8/19] RUN git clone https://github.com/pyenv/pyenv /opt/pyenv --branch v2.3.36 --depth 1                     0.4s
------
 > importing cache manifest from docker.io/overhangio/openedx-discovery:17.0.0-nightly-cache:
------
------
 > [minimal  8/19] RUN git clone https://github.com/pyenv/pyenv /opt/pyenv --branch v2.3.36 --depth 1:
0.341 fatal: could not create work tree dir '/opt/pyenv': Permission denied
------
Dockerfile:36
--------------------
  34 |     ENV PYENV_ROOT /opt/pyenv
  35 |     # USER root
  36 | >>> RUN git clone https://github.com/pyenv/pyenv $PYENV_ROOT --branch v2.3.36 --depth 1
  37 |     # Install Python
  38 |     RUN $PYENV_ROOT/bin/pyenv install $PYTHON_VERSION
--------------------
ERROR: failed to solve: process "/bin/sh -c git clone https://github.com/pyenv/pyenv $PYENV_ROOT --branch v2.3.36 --depth 1" did not complete successfully: exit code: 128
@regisb
Copy link
Contributor

regisb commented Apr 11, 2024

Does this mean that ecommerce is working with python 3.12? It would be absolutely fantastic, because we don't have anyone in the community to work on upgrading this IDA https://discuss.openedx.org/t/these-idas-will-not-be-upgraded-to-python-3-11-by-redwood/12755

@Faraz32123
Copy link
Collaborator Author

Does this mean that ecommerce is working with python 3.12? It would be absolutely fantastic, because we don't have anyone in the community to work on upgrading this IDA https://discuss.openedx.org/t/these-idas-will-not-be-upgraded-to-python-3-11-by-redwood/12755

Yes, ecommerce is working using these PRs, PR for ecommerce and PR for ecommerce-worker.
But still we need to update github workflows for ecommerce's PR as the tests are failing.

@Faraz32123
Copy link
Collaborator Author

moved this PR to blocked as this PR cannot be merged until PR for ecommerce and PR for ecommerce-worker didn't merge.

@Faraz32123 Faraz32123 merged commit 15344f0 into overhangio:nightly May 7, 2024
@Faraz32123 Faraz32123 deleted the enhancement/python_upgrade_to_v3.12.2 branch May 7, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants