Skip to content

Commit

Permalink
fix: double quotes added around CONTACT_EMAIL
Browse files Browse the repository at this point in the history
As mentioned in #51, when users have a CONTACT_EMAIL like My LMS <[email protected]>, the init task will fail simply because it contains whitespace and it's not a string.

Close #51
  • Loading branch information
CodeWithEmad committed Nov 29, 2023
1 parent e701ab9 commit ff34c52
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions tutorecommerce/templates/ecommerce/tasks/ecommerce/init
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
--sso-client-secret="{{ ECOMMERCE_OAUTH2_SECRET_SSO }}" \
--backend-service-client-id="{{ ECOMMERCE_OAUTH2_KEY_DEV }}" \
--backend-service-client-secret="{{ ECOMMERCE_OAUTH2_SECRET }}" \
--from-email={{ CONTACT_EMAIL }} \
--payment-support-email={{ CONTACT_EMAIL }} \
--from-email="{{ CONTACT_EMAIL }}" \
--payment-support-email="{{ CONTACT_EMAIL }}" \
--payment-support-url="http://{{ LMS_HOST }}:8000/support" \
--discovery_api_url=http://{{ DISCOVERY_HOST }}:8381/api/v1/ \
--enable-microfrontend-for-basket-page=true \
Expand All @@ -36,8 +36,8 @@
--sso-client-secret="{{ ECOMMERCE_OAUTH2_SECRET_SSO }}" \
--backend-service-client-id="{{ ECOMMERCE_OAUTH2_KEY }}" \
--backend-service-client-secret="{{ ECOMMERCE_OAUTH2_SECRET }}" \
--from-email={{ CONTACT_EMAIL }} \
--payment-support-email={{ CONTACT_EMAIL }} \
--from-email="{{ CONTACT_EMAIL }}" \
--payment-support-email="{{ CONTACT_EMAIL }}" \
--payment-support-url="{% if ENABLE_HTTPS %}https{% else %}http{% endif %}://{{ LMS_HOST }}/support" \
--discovery_api_url={% if ENABLE_HTTPS %}https{% else %}http{% endif %}://{{ DISCOVERY_HOST }}/api/v1/ \
--enable-microfrontend-for-basket-page=true \
Expand Down

0 comments on commit ff34c52

Please sign in to comment.