Skip to content

add HTTPParser #20049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 48 commits into from
May 31, 2025
Merged

add HTTPParser #20049

merged 48 commits into from
May 31, 2025

Conversation

dylan-conway
Copy link
Member

@dylan-conway dylan-conway commented May 30, 2025

What does this PR do?

adds HTTPParser to process.binding('http_parser'), and populates _http_common.

should probably move llhttp into cmake rather than copying a build

fixes:

  • test-http-parser.js
  • test-http-parser-bad-ref.js
  • test-http-parser-lazy-loaded.js

closes #13072

How did you verify your code works?

added node-http-parser.test.ts to test HTTPParser prototype functions that are not tested in test-http-parser.js. Also ConnectionsList is tested.

@robobun
Copy link

robobun commented May 30, 2025

Updated 11:19 PM PT - May 30th, 2025

@dylan-conway, your commit b2cfefa has 3 failures in Build #17833:


🧪   To try this PR locally:

bunx bun-pr 20049

That installs a local version of the PR into your bun-20049 executable, so you can run:

bun-20049 --bun

@dylan-conway dylan-conway marked this pull request as ready for review May 30, 2025 01:57
@kravetsone
Copy link

It's great! Thank you🎉

@Jarred-Sumner Jarred-Sumner merged commit ce8767c into main May 31, 2025
57 of 60 checks passed
@Jarred-Sumner Jarred-Sumner deleted the dylan/http-parser branch May 31, 2025 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement process.binding("http_parser")
5 participants