-
Notifications
You must be signed in to change notification settings - Fork 3.1k
add HTTPParser
#20049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
add HTTPParser
#20049
+15,353
−135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated 11:19 PM PT - May 30th, 2025
❌ @dylan-conway, your commit b2cfefa has 3 failures in
🧪 To try this PR locally: bunx bun-pr 20049 That installs a local version of the PR into your bun-20049 --bun |
8 tasks
It's great! Thank you🎉 |
Co-authored-by: Jarred Sumner <[email protected]>
nektro
requested changes
May 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
adds HTTPParser to process.binding('http_parser'), and populates _http_common.
should probably move
llhttp
into cmake rather than copying a buildfixes:
closes #13072
How did you verify your code works?
added
node-http-parser.test.ts
to testHTTPParser
prototype functions that are not tested intest-http-parser.js
. AlsoConnectionsList
is tested.