Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing x-amz-acl header #16260

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add missing x-amz-acl header #16260

wants to merge 1 commit into from

Conversation

Gobd
Copy link

@Gobd Gobd commented Jan 8, 2025

What does this PR do?

Closes #16255

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

@DonIsaac DonIsaac requested a review from cirospaciari January 8, 2025 21:59
@DonIsaac
Copy link
Contributor

DonIsaac commented Jan 8, 2025

Thanks for the PR @Gobd. It would be a big help if you could also add some test cases.

@Gobd
Copy link
Author

Gobd commented Jan 8, 2025

Sorry I'm not sure how I'd write a test for this :(

@Gobd
Copy link
Author

Gobd commented Jan 9, 2025

@cirospaciari using bunx bun-pr 16260 I can confirm that this fixes the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bun S3 acl option does not work
2 participants