Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(publish): missing bins bugfix #14488

Merged
merged 12 commits into from
Oct 12, 2024
Merged

fix(publish): missing bins bugfix #14488

merged 12 commits into from
Oct 12, 2024

Conversation

dylan-conway
Copy link
Collaborator

What does this PR do?

Correctly normalizes package binaries, and gives more package.json information to the registry.

fixes #14445

How did you verify your code works?

added tests

@robobun
Copy link

robobun commented Oct 11, 2024

@dylan-conway, your commit 0e06de3 has 9 failures in #4700:

  • test/js/bun/websocket/websocket-server.test.ts - timeout on 🍎 14 aarch64
  • test/js/web/streams/streams.test.js - 1 failing on 🍎 13 x64
  • test/js/web/streams/streams.test.js - 1 failing on 🍎 14 x64
  • test/js/web/fetch/fetch-tcp-stress.test.ts - 4 failing on 🍎 14 aarch64
  • test/js/web/fetch/fetch-tcp-stress.test.ts - timeout on 🍎 13 aarch64
  • test/js/web/fetch/fetch-tcp-stress.test.ts - timeout on 🍎 14 x64
  • test/js/web/fetch/fetch-tcp-stress.test.ts - 4 failing on 🍎 13 x64
  • test/cli/hot/watch.test.ts - 1 failing on 🪟 x64-baseline
  • test/cli/hot/watch.test.ts - 1 failing on 🪟 x64
  • test/bundler/bundler_compile.test.ts - 2 failing on 🪟 x64-baseline
  • test/cli/watch/watch.test.ts - 2 failing on 🪟 x64
  • test/cli/watch/watch.test.ts - 2 failing on 🪟 x64-baseline
  • test/js/node/test/parallel/child-process-exec-timeout-kill.test.js - 1 failing on 🍎 13 aarch64
  • test/js/bun/http/bun-serve-static.test.ts - 1 failing on 🍎 13 aarch64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🍎 13 aarch64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🍎 14 aarch64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🪟 x64-baseline
  • test/bundler/bun-build-api.test.ts - 3 failing on 🪟 x64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🍎 14 x64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🍎 13 x64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🐧 22.04 x64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🐧 12 x64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🐧 20.04 x64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🐧 22.04 aarch64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🐧 20.04 aarch64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🐧 12 aarch64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🐧 22.04 x64-baseline
  • test/bundler/bun-build-api.test.ts - 3 failing on 🐧 20.04 x64-baseline
  • test/bundler/bun-build-api.test.ts - 3 failing on 🐧 12 x64-baseline
  • @dylan-conway dylan-conway merged commit d3323c8 into main Oct 12, 2024
    25 checks passed
    @dylan-conway dylan-conway deleted the dylan/publish-bins-fix branch October 12, 2024 04:28
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    bun publish not work as expected
    3 participants