Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: --conditions flag #14463

Merged
merged 1 commit into from
Oct 10, 2024
Merged

docs: --conditions flag #14463

merged 1 commit into from
Oct 10, 2024

Conversation

RiskyMH
Copy link
Contributor

@RiskyMH RiskyMH commented Oct 10, 2024

I think this is the best place to document this old feature:
https://bun.sh/blog/bun-v1.0.30#new-flag-conditions (most is copied from the changelog)

What does this PR do?

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

I think this is the best place to document this old feature: 
https://bun.sh/blog/bun-v1.0.30#new-flag-conditions (most is copied from the changelog)
@robobun
Copy link

robobun commented Oct 10, 2024

@RiskyMH, your commit ec51f0e has 10 failures in #4622:

  • test/js/web/streams/streams.test.js - 1 failing on 🍎 13 x64
  • test/v8/v8.test.ts - 24 failing on 🐧 22.04 aarch64
  • test/js/web/fetch/fetch-tcp-stress.test.ts - timeout on 🍎 14 aarch64
  • test/js/web/fetch/fetch-tcp-stress.test.ts - timeout on 🍎 13 x64
  • test/js/web/fetch/fetch-tcp-stress.test.ts - 4 failing on 🍎 14 x64
  • test/js/bun/http/fetch-file-upload.test.ts - 1 failing on 🪟 x64
  • test/js/bun/http/fetch-file-upload.test.ts - 1 failing on 🪟 x64-baseline
  • test/cli/watch/watch.test.ts - 2 failing on 🪟 x64
  • test/cli/watch/watch.test.ts - 2 failing on 🪟 x64-baseline
  • test/cli/hot/watch.test.ts - 1 failing on 🪟 x64-baseline
  • test/cli/hot/watch.test.ts - 1 failing on 🪟 x64
  • test/bundler/bundler_edgecase.test.ts - 1 failing on 🪟 x64-baseline
  • test/js/node/test/parallel/child-process-exec-timeout-kill.test.js - 1 failing on 🍎 14 aarch64
  • test/js/bun/http/bun-serve-static.test.ts - 1 failing on 🍎 13 aarch64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🍎 13 aarch64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🍎 14 aarch64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🪟 x64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🪟 x64-baseline
  • test/bundler/bun-build-api.test.ts - 3 failing on 🐧 22.04 x64-baseline
  • test/bundler/bun-build-api.test.ts - 3 failing on 🐧 20.04 x64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🐧 22.04 x64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🐧 20.04 x64-baseline
  • test/bundler/bun-build-api.test.ts - 3 failing on 🐧 12 x64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🐧 12 x64-baseline
  • test/bundler/bun-build-api.test.ts - 3 failing on 🍎 14 x64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🍎 13 x64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🐧 22.04 aarch64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🐧 12 aarch64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🐧 20.04 aarch64
  • @Jarred-Sumner Jarred-Sumner merged commit 05f68d7 into main Oct 10, 2024
    21 of 25 checks passed
    @Jarred-Sumner Jarred-Sumner deleted the riskymh/docs/conditions branch October 10, 2024 11:05
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants