Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix napi_throw_*/napi_create_*_error #14446

Merged
merged 5 commits into from
Oct 10, 2024
Merged

Conversation

190n
Copy link
Contributor

@190n 190n commented Oct 9, 2024

What does this PR do?

Fixes bugs in the NAPI functions to create or throw Error functions, and adds exhaustive tests for them.

How did you verify your code works?

  • I included a test for the new code, or existing tests cover it
  • I ran my tests locally and they pass (bun-debug test test-file-name.test)

@robobun
Copy link

robobun commented Oct 9, 2024

@190n, your commit 6cc947d has 13 failures in #4594:

  • test/js/web/fetch/fetch-tcp-stress.test.ts - 4 failing on 🍎 14 x64
  • test/js/bun/http/fetch-file-upload.test.ts - 1 failing on 🪟 x64-baseline
  • test/js/web/timers/setInterval.test.js - 1 failing on 🪟 x64-baseline
  • test/cli/watch/watch.test.ts - 2 failing on 🪟 x64
  • test/cli/watch/watch.test.ts - 2 failing on 🪟 x64-baseline
  • test/js/web/fetch/fetch.tls.test.ts - 1 failing on 🪟 x64-baseline
  • test/bundler/bundler_compile.test.ts - 5 failing on 🪟 x64-baseline
  • test/js/bun/http/bun-serve-static.test.ts - 1 failing on 🍎 13 aarch64
  • test/cli/hot/watch.test.ts - 1 failing on 🪟 x64
  • test/cli/hot/watch.test.ts - 1 failing on 🪟 x64-baseline
  • test/bundler/bundler_edgecase.test.ts - 1 failing on 🪟 x64
  • test/bundler/bundler_edgecase.test.ts - 1 failing on 🪟 x64-baseline
  • test/js/bun/http/bun-serve-static.test.ts - annotation error on 🍎 14 aarch64
  • test/js/bun/spawn/spawn-stdin-destroy.test.ts - 1 failing on 🪟 x64
  • test/js/node/test/parallel/child-process-exec-timeout-kill.test.js - 1 failing on 🍎 13 aarch64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🍎 14 aarch64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🍎 13 aarch64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🍎 14 x64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🍎 13 x64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🪟 x64-baseline
  • test/bundler/bun-build-api.test.ts - 3 failing on 🪟 x64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🐧 22.04 x64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🐧 20.04 x64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🐧 12 x64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🐧 20.04 aarch64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🐧 22.04 aarch64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🐧 12 aarch64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🐧 22.04 x64-baseline
  • test/bundler/bun-build-api.test.ts - 3 failing on 🐧 12 x64-baseline
  • test/bundler/bun-build-api.test.ts - 3 failing on 🐧 20.04 x64-baseline
  • @190n 190n marked this pull request as ready for review October 10, 2024 00:01
    @Jarred-Sumner Jarred-Sumner merged commit 50bb5fa into main Oct 10, 2024
    25 checks passed
    @Jarred-Sumner Jarred-Sumner deleted the ben/napi-throw-empty-msg branch October 10, 2024 09:35
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants