Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CA support for bun install #14416

Merged
merged 22 commits into from
Oct 11, 2024
Merged

CA support for bun install #14416

merged 22 commits into from
Oct 11, 2024

Conversation

dylan-conway
Copy link
Collaborator

@dylan-conway dylan-conway commented Oct 8, 2024 •
edited
Loading

What does this PR do?

  • --ca
  • --cafile
  • bunfig ca
  • bunfig cafile

closes #271

How did you verify your code works?

  • valid CA and cafile from cli and bunfig
  • invalid CA and cafile

@robobun
Copy link

robobun commented Oct 8, 2024 •
edited
Loading

❌ @dylan-conway, your commit 777d071 has 11 failures in #4665:

  • test/js/web/fetch/fetch-tcp-stress.test.ts - 4 failing on 🍎 14 x64
  • test/v8/v8.test.ts - 22 failing on 🐧 12 aarch64
  • test/v8/v8.test.ts - 22 failing on 🐧 22.04 aarch64
  • test/v8/v8.test.ts - 22 failing on 🐧 20.04 aarch64
  • test/js/web/streams/streams.test.js - 1 failing on 🍎 13 x64
  • test/js/bun/http/fetch-file-upload.test.ts - 1 failing on 🪟 x64-baseline
  • test/js/node/test/parallel/zlib.test.js - 1 failing on 🍎 14 aarch64
  • test/js/node/test/parallel/zlib.test.js - 1 failing on 🍎 13 aarch64
  • test/bundler/bundler_compile.test.ts - 7 failing on 🪟 x64
  • test/bundler/bundler_compile.test.ts - 6 failing on 🪟 x64-baseline
  • test/cli/run/require-cache.test.ts - 1 failing on 🪟 x64
  • test/cli/hot/watch.test.ts - 1 failing on 🪟 x64
  • test/cli/hot/watch.test.ts - 1 failing on 🪟 x64-baseline
  • test/js/bun/http/bun-serve-static.test.ts - 2 failing on 🍎 13 aarch64
  • test/cli/watch/watch.test.ts - 2 failing on 🪟 x64
  • test/cli/watch/watch.test.ts - 2 failing on 🪟 x64-baseline
  • test/bundler/bun-build-api.test.ts - 3 failing on 🍎 13 aarch64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🍎 14 aarch64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🍎 13 x64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🪟 x64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🪟 x64-baseline
  • test/bundler/bun-build-api.test.ts - 3 failing on 🐧 20.04 x64-baseline
  • test/bundler/bun-build-api.test.ts - 3 failing on 🐧 12 x64-baseline
  • test/bundler/bun-build-api.test.ts - 3 failing on 🐧 22.04 x64-baseline
  • test/bundler/bun-build-api.test.ts - 3 failing on 🐧 22.04 x64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🐧 12 x64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🐧 20.04 x64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🍎 14 x64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🐧 22.04 aarch64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🐧 12 aarch64
  • test/bundler/bun-build-api.test.ts - 3 failing on 🐧 20.04 aarch64
    		•

    @dylan-conway dylan-conway marked this pull request as ready for review October 9, 2024 23:24
    dylan-conway
    dylan-conway commented Oct 10, 2024
    View reviewed changes
    src/http.zig
    return err;

    // TODO: these error names reach js. figure out how they should be handled
    return switch (err) {
    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Because it's a little out of scope for this pr, I return error.FailedToOpenSocket for each error. Open to changing this

    @cirospaciari cirospaciari merged commit 5fd0a61 into main Oct 11, 2024
    25 checks passed
    @cirospaciari cirospaciari deleted the dylan/certificate-authority branch October 11, 2024 20:16
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @cirospaciari cirospaciari cirospaciari approved these changes

    @Jarred-Sumner Jarred-Sumner Awaiting requested review from Jarred-Sumner

    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    CA support for SSL connection to NPM registries
    3 participants
    @dylan-conway @robobun @cirospaciari