Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate exceptions in napi_run_script #14222

Merged
merged 2 commits into from
Sep 28, 2024

Conversation

190n
Copy link
Contributor

@190n 190n commented Sep 28, 2024

What does this PR do?

Fixes napi_run_script to not swallow exceptions thrown by the eval'd script

How did you verify your code works?

Updated napi tests to cover napi_run_script in some edge cases + normal cases.

  • I included a test for the new code, or existing tests cover it
  • I ran my tests locally and they pass (bun-debug test test-file-name.test)

@190n 190n marked this pull request as ready for review September 28, 2024 01:49
@Jarred-Sumner Jarred-Sumner merged commit dd12715 into main Sep 28, 2024
48 checks passed
@Jarred-Sumner Jarred-Sumner deleted the ben/napi-run-script-exception branch September 28, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants