Merge pull request #640 from KristianAN/master

Fixes SlackWriter to evaluate the IO.
outr · Oct 19, 2024 · 5b56d4d · 5b56d4d
2 parents 47d0bf7 + 749b65c
commit 5b56d4d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/logstash/src/main/scala/scribe/logstash/LogstashWriter.scala b/logstash/src/main/scala/scribe/logstash/LogstashWriter.scala
@@ -23,7 +23,7 @@ case class LogstashWriter(url: URL,
   private lazy val client = HttpClient.url(url).post
 
   override def write(record: LogRecord, output: LogOutput, outputFormat: OutputFormat): Unit = {
-    val io = log(record)
+    val io = log(record) // Does nothing
     if (!asynchronous) {
       io.unsafeRunSync()
     }
@@ -57,4 +57,4 @@ case class LogstashWriter(url: URL,
     val content = Content.json(json.merge(additional))
     client.content(content).send()
   }
-}
+}
diff --git a/slack/src/main/scala/scribe/slack/SlackWriter.scala b/slack/src/main/scala/scribe/slack/SlackWriter.scala
@@ -4,6 +4,7 @@ import scribe.LogRecord
 import scribe.output.LogOutput
 import scribe.output.format.OutputFormat
 import scribe.writer.Writer
+import cats.effect.unsafe.implicits.global
 
 /**
   * SlackWriter is
@@ -12,8 +13,10 @@ import scribe.writer.Writer
   * @param emojiIcon the emoji to use when sending messages
   */
 class SlackWriter(slack: Slack, emojiIcon: String) extends Writer {
+
   override def write(record: LogRecord, output: LogOutput, outputFormat: OutputFormat): Unit = slack.request(
     message = output.plainText,
     emojiIcon = emojiIcon
-  )
-}
+  ).unsafeRunAndForget()
+
+}