Chance to elaborate currencies with not just precision 2 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… I am not mainly a developer Can be a way to fix the currencies that doesn't have the 2 decimals. Please check at tests too in case i modified em wrongly
In add I suppose will have other implications I didn t discover yet
|
I found also that some case class has some problem on reading the output form the api when now is handling more currencies, I added an awful patch on Charge class that are these 2 val inside It is a completely wrong approach but I don t know circe enough to handle this with the Decoder/Encoder handling |
- Parameter chargeId is mandatory. - Refund model has some missing fields.
|
You need to resolve conflicts with master. |
|
Hello, I will take a view to it eheh at the moment I ve other priorities, has been a crazy period, I will review them as soon as i can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to adapt the code to manage also currencies that doesn t have digits or that have different dthan 2 digits after the decimal point (unfortunately I cannot test the non 2 or 0 because stripe at the moment is not supporting them if I am in right)