Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix and update tune_pytorch example #14

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

madhur-ob
Copy link
Contributor

No description provided.

Copy link
Member

@valayDave valayDave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs fixing some NITs. Also make a few values like batch_size into parameters.

examples/tune_pytorch/utils.py Outdated Show resolved Hide resolved
examples/tune_pytorch/flow_gpu.py Outdated Show resolved Hide resolved
examples/tune_pytorch/flow_gpu.py Outdated Show resolved Hide resolved
examples/tune_pytorch/flow_gpu.py Outdated Show resolved Hide resolved
test_size=self.test_size,
num_samples=self.num_samples,
smoke_test=True,
run_config_storage_path=current.ray_storage_path,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ray will be writing every experiment in a subdirectory. Can we find a way to pull that out of the task and save it to self so that users can use that later.

examples/tune_pytorch/utils.py Outdated Show resolved Hide resolved
@madhur-ob madhur-ob requested a review from valayDave December 24, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants