Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra semicolon. #598

Closed
wants to merge 1 commit into from

Conversation

jackg0
Copy link

@jackg0 jackg0 commented May 22, 2024

Related Issues & PRs

I noticed the following build error on my machine:

In file included from /opt/src/lidar-mapping/src/include/lidar_mapping/utilities.hh:21,
                 from /opt/src/lidar-mapping/src/utilities.cc:14:
/opt/src/lidar-mapping/deps/ouster_example/ouster_client/include/ouster/lidar_scan.h:146:62: error: extra ‘;’ [-Werror=pedantic]
  146 |         : LidarScan(w, h, {begin, end}, columns_per_packet){};
      |                                                              ^
      |                                                              -

Summary of Changes

Removed the extra semicolon.

Validation

Built successfully.

@Samahu Samahu self-requested a review May 22, 2024 22:28
Copy link
Collaborator

@Samahu Samahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that

@Samahu
Copy link
Collaborator

Samahu commented Aug 6, 2024

Included in #604

@Samahu Samahu closed this Aug 6, 2024
@Samahu Samahu assigned matthew-lidar and unassigned twslankard Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants