AO3-6880 Use pagy gem for pagination on select pages

[ceithir]

Pull Request Checklist

• Have you read "How to write the perfect pull request"?
• Have you read the contributing guidelines?
• Have you added tests for any changed functionality?
• Have you added the Jira issue number as the first thing in your pull request title (e.g. AO3-1234 Fix thing)
• Do you have fewer than 5 pull requests already open? If not, please wait until they are reviewed and merged before creating new pull requests.

Issue

https://otwarchive.atlassian.net/browse/AO3-6880

Purpose

As per ticket.

Visible (frontend) differences from will_paginate:

• rel="prev" and rel="next" have disappeared but seem to be obsolete anyway (cf https://developers.google.com/search/docs/specialty/ecommerce/pagination-and-incremental-page-loading)
• Weird title attributes (all equal to an untranslated "pagination" string) have not made the cut
• Blank space characters between <li> tags have been removed. In other words, the HTML was previously </li> <li> and is now </li><li>. This means the pagination is slightly more compact looking. Maybe need to add back some padding in CSS?
• will_paginate was always showing the first two and the last two items in the list (1 2 ... <> ... 312 313) while pagy only shows the very first and the last (1 ... <> ... 313). There doesn't seem to be an option to modify that behavior without going into the code (cf Pagy#series). Unsure if worth it.

Before/after pictures:

Testing Instructions

In theory, everything should be working as before on the three modified pages, except for the minor changes listed above.

Credit

Ceithir (he/him)

[ceithir]

Supposedly, the Brakeman warnings should be ignored. Not sure if/how I can tell Github Actions to ignore them on my side (our doc only refers to the local ignore file)

[ceithir]

Keeping the same behavior as now by not showing the pagination in case of overflow ("page 66 of 10").

pagy's alternative options for reference.

[redsummernight]

Since we're not setting Pagy::DEFAULT[:overflow], the default is :empty_page instead of :exception, do we need to wrap calls in pagy_overflow_handler?

[ceithir]

Without the require 'pagy/extras/overflow' line, Pagy always raises an exception in case of overflow (source)

[redsummernight]

Supposedly, the Brakeman warnings should be ignored. Not sure if/how I can tell Github Actions to ignore them on my side (our doc only refers to the local ignore file)

You can add pagy_nav as a safe method in config/brakeman.yml.

We stopped keeping the ignore file in the repo since #4158. I'll update the wiki.

[redsummernight]

Since we're not setting Pagy::DEFAULT[:overflow], the default is :empty_page instead of :exception, do we need to wrap calls in pagy_overflow_handler?

[redsummernight]

Looks good, thank you!