-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AO3-6791 Raise 404 when editing a pseud for a user that doesn't exist #5047
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small fix to the test name please, rest looks good!
@@ -76,6 +76,11 @@ | |||
subject.call | |||
expect(response).to render_template(:edit) | |||
end | |||
|
|||
it "returns NotFound error when pseud doesn't exist" do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it "returns NotFound error when pseud doesn't exist" do | |
it "returns NotFound error when user doesn't exist" do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing
)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-6791
Purpose
When navigating to a pseud edit page for a user that doesn't exist (/users/fake_user/pseuds/pseud/edit), we should return a 404 error, instead of a 500
Testing Instructions
Replication steps from JIRA:
References
Are there other relevant issues/pull requests/mailing list discussions?
Linked jira issue AO3-6790 to raise 404 when editing a pseud that doesn't exist, and its PR.
Credit
lou (she/her)