AO3-6847 Create anonymous_or_unrevealed_notification mailer preview #5040
+117
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianjaustin
requested changes
Jan 31, 2025
| @@ -63,3 +63,65 @@ Feature: Collectible items email | |||
| And I fill in "bookmark_collection_names" with "dont_bookmark_me_bro" | |||
| And I press "Create" | |||
| Then 1 email should be delivered | |||
|
|
|||
| Scenario: Scenario: Translated email is sent when the status of a Collection item is changed to anonymous | |||
There was a problem hiding this comment.
Duplicate "Scenario"
Suggested change
| Scenario: Scenario: Translated email is sent when the status of a Collection item is changed to anonymous | |
| Scenario: Translated email is sent when the status of a Collection item is changed to anonymous |
| And the email should have "Your work was made anonymous" in the subject | ||
| And the email to "user1" should be translated | ||
|
|
||
| Scenario: Scenario: Translated email is sent when the status of a Collection item is changed to unrevealed |
There was a problem hiding this comment.
Duplicate "Scenario"
Suggested change
| Scenario: Scenario: Translated email is sent when the status of a Collection item is changed to unrevealed | |
| Scenario: Translated email is sent when the status of a Collection item is changed to unrevealed |
| And the email should have "Your work was made unrevealed" in the subject | ||
| And the email to "user1" should be translated | ||
|
|
||
| Scenario: Scenario: Translated email is sent when the status of a Collection item is changed to anonymous and unrevealed |
There was a problem hiding this comment.
Duplicate "Scenario"
Suggested change
| Scenario: Scenario: Translated email is sent when the status of a Collection item is changed to anonymous and unrevealed | |
| Scenario: Translated email is sent when the status of a Collection item is changed to anonymous and unrevealed |
| And I submit | ||
| Then "user1" should be emailed | ||
| And the email should have "Your work was made anonymous and unrevealed" in the subject | ||
| And the email to "user1" should be translated |
There was a problem hiding this comment.
Please add a trailing newline to the file https://stackoverflow.com/a/5813359
Comment on lines
+62
to
+63
| subject: t(".subject.#{@status}", | ||
| app_name: ArchiveConfig.APP_SHORT_NAME) |
There was a problem hiding this comment.
Suggested change
| subject: t(".subject.#{@status}", | |
| app_name: ArchiveConfig.APP_SHORT_NAME) | |
| subject: t(".subject.#{@status}", | |
| app_name: ArchiveConfig.APP_SHORT_NAME) |
| @@ -112,6 +112,42 @@ def change_email | |||
| new_email = "new_email" | |||
| UserMailer.change_email(user.id, old_email, new_email) | |||
| end | |||
|
|
|||
| # Sends email when collection item changes status | |||
| [:anonymous_unrevealed_collection, :anonymous_collection, :unrevealed_collection].each do |status| | |||
There was a problem hiding this comment.
I don't think this loop is doing exactly what you want. For example, should the first method be more like the following?
def anonymous_unrevealed_collection_notification
user, collection, item = anonymous_or_unrevealed_data(:anonymous_unrevealed_collection)
newly_anonymous = true
newly_unrevealed = true
UserMailer.anonymous_or_unrevealed_notification(
user.id, item.id, collection.id,
anonymous: newly_anonymous, unrevealed: newly_unrevealed
)
endOtherwise, I think the status needs to be in the method name to avoid new definitions overriding previous ones (I only see anonymous_unrevealed_collection_notification once on /rails/mailers for example)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-6847
Purpose
Add mailer preview for the
anonymous_or_unrevealed_notificationemail.Include cucumber test for sending a translated
anonymous_or_unrevealed_notificationemail to a user.Remove the redundant
html_safecall in the HTML mail.Testing Instructions
See Jira.
References
Credit
Amy Lee