AO3-6888 Better align tags and stats in work meta #5033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavalamp
suggested changes
Jan 25, 2025
Comment on lines
31
to
34
| .meta .stats dl dd, .meta .stats dl dt { | ||
| margin-block: 0 auto; | ||
| /* the 0.375em margin previously used here + 0.25em padding-left from .stats>* that is zeroed out in the ruleset below */ | ||
| margin-inline: 0 0.625em; | ||
| margin-inline: 0 0.375em; | ||
| padding-inline-end: 0.25em; |
There was a problem hiding this comment.
This makes the space between stats smaller because the margin used to add up to dl.stats dd's padding-right: 0.5em; from 10-types-groups.css but padding-inline seems to overwrite it
I think .meta .stats dl dd should have padding-inline-end: 0.75em; instead
redsummernight
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://otwarchive.atlassian.net/browse/AO3-6888
Purpose
Fixes the alignment of tags and stats in work meta when the lines wrap.
I used
margin-block,margin-inline,padding-block, andpadding-inlinebecause there's a slight improvement whenddorul) hasdir="rtl"applied, andThe improvement? The comma was on the left of the English tag (i.e., it obeyed the direction rules of the container) instead of the right.
We won't ever actually encounter that scenario with the current code, but hey, let's do it anyway.
Testing Instructions
Refer to Jira.
References
#1919 and #1930
Credit
Sarken, she/her