Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Clarify workflow for contributions and Jira #5010

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Bilka2
Copy link
Contributor

@Bilka2 Bilka2 commented Jan 5, 2025

Issue

None, doc change.

Purpose

Improve the documentation of the code contribution workflow by turning it into an ordered list. This makes the order of the steps more clear, especially in regards to Jira account permissions. Mention the Jira account permissions in the readme, together with the mailing list.

References

Internal discussion from Dec 27 and Dec 30.

Credit

Bilka

CONTRIBUTING.md Show resolved Hide resolved
@@ -22,7 +22,8 @@ We welcome pull requests for bugs described in our issue tracker. Please see our
* [Developer Documentation](https://github.com/otwcode/otwarchive/wiki)
* [Commit Policy](https://github.com/otwcode/otwarchive/wiki/Commit-policy)

We do not have a public chat, but you are welcome to contact us at [email protected] if you have any questions.
We do not have a public chat, but you are welcome to contact us at [email protected] if you have any questions.
We grant your Jira account permissions for commenting on, assigning, and transitioning issues [after you create your first pull request](https://github.com/otwcode/otwarchive/blob/master/CONTRIBUTING.md#workflow).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this is meant to be a different paragraph than the part about the chat, so I think we need a blank line between the two lines.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's meant to be a linebreak but not a different paragraph, like this.
Second sentence.

So my question is whether we want that formatting or if a new paragraph would be more standard. I'd be fine with either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants