AO3-6868 Add language form validation

[connie-feng]

Pull Request Checklist

• Have you read "How to write the perfect pull request"?
• Have you read the contributing guidelines?
• Have you added tests for any changed functionality?
• Have you added the Jira issue number
  as the first thing in your pull request title (e.g. AO3-1234 Fix thing)
• Do you have fewer than 5 pull requests already open? If not, please wait
  until they are reviewed and merged before creating new pull requests.

Issue

https://otwarchive.atlassian.net/browse/AO3-6868

Purpose

This adds two form validations to the language form on the /languages/<language abbreviation/edit page:

• validates that the display name is not a duplicate
• validates that the abbreviation is 4 characters or fewer

Also:

• added rake task to check for duplicate language names before running migrations
  • rake db:check_language_name_duplicates
• fixed some existing tests that were failing on the new validations and rubocop

Testing Instructions

1. Login as an admin
2. Go to /languages
3. Click Edit on any of the languages
4. Change the display name to one that already exists
5. Change the abbreviation to something with more than 5 characters
6. Click Update Language and form validations should appear

Credit

Connie Feng, she/her
(JIRA account)

[brianjaustin]

Hi, Connie, thanks for the pull request!

A couple small comments for you, and noting for myself that we'll want to run a query before the migration is run to check for duplicate language names. (If you feel confident in writing a Before rake task to do that, it would be helpful but the query should be easy by hand as well so don't worry about it either way!)

I've assigned the Jira issue to you and set its status to In Review so no one will mistakenly create a duplicate pull request. I've also given your account permission to comment on, assign, and transition issues in the future.

Thanks again for contributing! If you have any questions, you can contact us at [email protected].

[Bilka2]

Please revert the update to schema.rb, we prefer not to update the schema dump in unrelated PRs (refer to #4677).

[connie-feng]

Please revert the update to schema.rb, we prefer not to update the schema dump in unrelated PRs (refer to #4677).

Hi @Bilka2! I've reverted the update to schema.rb, but it does cause rubocop to fail (example: https://github.com/otwcode/otwarchive/actions/runs/12519083042) -- should I disable rubocop for those specific lines?

[connie-feng]

Hi, Connie, thanks for the pull request!

A couple small comments for you, and noting for myself that we'll want to run a query before the migration is run to check for duplicate language names. (If you feel confident in writing a Before rake task to do that, it would be helpful but the query should be easy by hand as well so don't worry about it either way!)

Hi @brianjaustin -- thanks! I will add the Before rake task :)

[Bilka2]

Hi @Bilka2! I've reverted the update to schema.rb, but it does cause rubocop to fail (example: https://github.com/otwcode/otwarchive/actions/runs/12519083042) -- should I disable rubocop for those specific lines?

You technically fixed the failure with the migration so it's fine to just keep it enabled. We'll ignore the failure when reviewing this PR since it's clear that it was addressed.

[brianjaustin]

Thanks for the rake task! Just 1 thing I missed on my first review, otherwise looks good!

[brianjaustin]

Thanks!