OD-1724 Remove Chapters.AuthorID from Rails Schema #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ariana-paris
approved these changes
Oct 22, 2023
db/schema.rb
Outdated
|
|
||
| create_table "archive_configs", id: :integer, options: "ENGINE=MyISAM DEFAULT CHARSET=utf8", force: :cascade do |t| | ||
| create_table "archive_configs", id: :integer, options: "ENGINE=MyISAM DEFAULT CHARSET=utf8mb3 COLLATE=utf8mb3_general_ci", force: :cascade do |t| |
There was a problem hiding this comment.
I realise utf8 is an alias for ut8mb3 so this is correct, and all that gets overridden anyway when an ODAP-produced database is loaded into the db. But since the Rails app is configured for utf8mb4 it might be less confusing if schema.rb was too.
There was a problem hiding this comment.
Just did a migration to update this accordingly, also manually updated structure.sql
ariana-paris
approved these changes
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes (except for structure.sql, which was manual) are the result of running the following commands: