Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silhouette Plot #247

Merged
merged 8 commits into from
Aug 5, 2020
Merged

Silhouette Plot #247

merged 8 commits into from
Aug 5, 2020

Conversation

AnGWar26
Copy link
Contributor

@AnGWar26 AnGWar26 commented Aug 5, 2020

In response to #202

- prep for silhoutte plotting
- enables us to pass info about the models much more easily

Ex: comm.models.['ward'].X will give the X of the 'ward' model
@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

Merging #247 into master will decrease coverage by 17.86%.
The diff coverage is 81.81%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #247       +/-   ##
===========================================
- Coverage   81.98%   64.12%   -17.87%     
===========================================
  Files          12       12               
  Lines         816      825        +9     
===========================================
- Hits          669      529      -140     
- Misses        147      296      +149     
Impacted Files Coverage Δ
geosnap/_community.py 69.09% <50.00%> (-6.69%) ⬇️
geosnap/analyze/analytics.py 72.17% <100.00%> (+1.26%) ⬆️
geosnap/analyze/dynamics.py 22.58% <0.00%> (-77.42%) ⬇️
geosnap/io/storage.py 24.66% <0.00%> (-70.67%) ⬇️
geosnap/io/util.py 48.83% <0.00%> (-30.24%) ⬇️
geosnap/_data.py 74.11% <0.00%> (+3.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9a6096...d1ab1da. Read the comment docs.

@knaaptime knaaptime merged commit 73bb8b1 into oturns:master Aug 5, 2020
@knaaptime knaaptime mentioned this pull request Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants