Fix bug: Cooldown interval config used instead of report interval #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitlicht
approved these changes
Nov 22, 2023
NetanelBollag
deleted the
netanelb/fix-bug/report-inteval-config-not-working
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Until this PR the
kafka-cooldown-intervalargument was used to set the time between reports to the network mapper instead ofkafka-report-interval. This PR change it to read the right configuration.Testing
Since it's an infrastructural low level detail there is no test who check the interval. It can be reproduce by setting a value to report interval argument and checking time between reports in the logs.
Checklist
There is no new functionality to document