Don't recreate stackables every move #4873
Open
+33
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nekiro
force-pushed
the
dont-recreate-stackables
branch
from
44891b5 to
cb1442f
Compare
Tofame
approved these changes
Dec 11, 2024
Tofame
approved these changes
Dec 17, 2024
ArturKnopik
approved these changes
Dec 19, 2024
ArturKnopik
requested changes
Dec 19, 2024
nekiro
force-pushed
the
dont-recreate-stackables
branch
6 times, most recently
from
7d91e25 to
43ae494
Compare
ArturKnopik
requested changes
Dec 20, 2024
nekiro
added
enhancement
nekiro
force-pushed
the
dont-recreate-stackables
branch
from
43ae494 to
5948ea0
Compare
nekiro
force-pushed
the
dont-recreate-stackables
branch
from
5948ea0 to
a3ced86
Compare
ArturKnopik
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Follow up to #4761
Don't recreate stackables on every move, create new stackables only when really needed.
Issues addressed:
Stackable items are recreated even when they shouldn't, if you move a full stack of stackable item, why would you create a new item and delete the old one?
This seems pretty wasteful and unnecessary.
How to test:
Play with stackables