Add packet compression

[nekiro]

Pull Request Prelude

• I have followed proper The Forgotten Server code styling.
• I have read and understood the contribution guidelines before making this PR.
• I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

Add missing packet compression for big packets

Issues addressed:
None

How to test:
Login to game, walk around, no crashes? works

[kojimhojo]

I was test this pr

1>D:\src\protocol.h(55,22): warning C4018: '>=': signed/unsigned mismatch
1>(compiling source file '/theforgo.A10F9657/x64/Release/unity_7UV282A0LJD6HKYT.cpp')
1>D:\src\protocol.h(55,22): warning C4018: '>=': signed/unsigned mismatch
1>(compiling source file '/theforgo.A10F9657/x64/Release/unity_WVPT28ZTJM2D5DRQ.cpp')
1>D:\src\protocol.h(55,22): warning C4018: '>=': signed/unsigned mismatch
1>(compiling source file '/theforgo.A10F9657/x64/Release/unity_PHA839T1F3WJNADU.cpp')
1>D:\src\protocol.h(55,22): warning C4018: '>=': signed/unsigned mismatch
1>(compiling source file '/theforgo.A10F9657/x64/Release/unity_UQQ0CKG94LMSIJTD.cpp')
1>D:\src\protocol.h(55,22): warning C4018: '>=': signed/unsigned mismatch
1>(compiling source file '/theforgo.A10F9657/x64/Release/unity_BY0BRRYLGSJPV7M2.cpp')
1>D:\src\protocol.h(55,22): warning C4018: '>=': signed/unsigned mismatch
1>(compiling source file '/theforgo.A10F9657/x64/Release/unity_CC66XSVYT629IPHD.cpp')
1>D:\src\protocol.h(55,22): warning C4018: '>=': signed/unsigned mismatch
1>(compiling source file '/theforgo.A10F9657/x64/Release/unity_O3UET4IWMWPEWHUH.cpp')
1>D:\src\protocol.h(55,22): warning C4018: '>=': signed/unsigned mismatch
1>(compiling source file '/theforgo.A10F9657/x64/Release/unity_JLP2YU5E50UTN58Y.cpp')
1>D:\src\protocol.h(55,22): warning C4018: '>=': signed/unsigned mismatch
1>(compiling source file '/theforgo.A10F9657/x64/Release/unity_3IXG4BE2WK51GMUG.cpp')
1>D:\src\protocol.h(55,22): warning C4018: '>=': signed/unsigned mismatch
1>(compiling source file '/theforgo.A10F9657/x64/Release/unity_W77GNRDQU6L8J5J6.cpp')
1>D:\src\protocol.h(55,22): warning C4018: '>=': signed/unsigned mismatch
1>(compiling source file '/theforgo.A10F9657/x64/Release/unity_DEI15LZQFC5MQXGQ.cpp')
1>D:\src\protocol.h(55,22): warning C4018: '>=': signed/unsigned mismatch
1>(compiling source file '/theforgo.A10F9657/x64/Release/unity_M5357L0YAAIQIYYX.cpp')
1>D:\src\protocol.h(55,22): warning C4018: '>=': signed/unsigned mismatch
1>(compiling source file '/theforgo.A10F9657/x64/Release/unity_CUC7PH7VGPESK21R.cpp')
1>D:\src\protocol.h(55,22): warning C4018: '>=': signed/unsigned mismatch
1>(compiling source file '/theforgo.A10F9657/x64/Release/unity_FZXZHF2F6A11DIV8.cpp')
1>D:\src\protocol.h(55,22): warning C4018: '>=': signed/unsigned mismatch
1>(compiling source file '/theforgo.A10F9657/x64/Release/unity_6PQ6CCA4WWXC3I24.cpp')
1>D:\src\outputmessage.cpp(25,55): warning C4459: declaration of 'bufferedProtocols' hides global declaration
1>(compiling source file '/theforgo.A10F9657/x64/Release/unity_CUC7PH7VGPESK21R.cpp')
1>D:\src\outputmessage.cpp(21,27):
1>see declaration of '`anonymous-namespace'::bufferedProtocols'
1>D:\src\outputmessage.cpp(31,47): warning C4459: declaration of 'bufferedProtocols' hides global declaration
1>(compiling source file '/theforgo.A10F9657/x64/Release/unity_CUC7PH7VGPESK21R.cpp')
1>D:\src\outputmessage.cpp(21,27):
1>see declaration of '`anonymous-namespace'::bufferedProtocols'
1>unity_8NZJOI7GO26MNSLA.cpp
1>D:\src\protocol.h(55,22): warning C4018: '>=': signed/unsigned mismatch
1>(compiling source file '/theforgo.A10F9657/x64/Release/unity_FZXZHF2F6A11DIV8.cpp')
1>D:\src\protocol.h(55,22): warning C4018: '>=': signed/unsigned mismatch
1>(compiling source file '/theforgo.A10F9657/x64/Release/unity_8NZJOI7GO26MNSLA.cpp')

in cipsoft client works fine

but in otc by enabling the feature "GameSequencedPackets"
g_game.enableFeature(GameSequencedPackets)

mehah/otclient@4e79004
"SPX Protocol Support (with compress)"

error

ERROR: failed to decompress message - too many length or distance symbols
at:
    [C++]: ?internalRecvData@Protocol@@AEAAXPEAEG@Z
    
    ERROR: failed to decompress message - invalid stored block lengths
at:
    [C++]: ?internalRecvData@Protocol@@AEAAXPEAEG@Z

[nekiro]

in cipsoft client works fine

but in otc by enabling the feature "GameSequencedPackets" g_game.enableFeature(GameSequencedPackets)

mehah/otclient@4e79004 "SPX Protocol Support (with compress)"

If cip client works, then it must be something different at otclient side or incorrect configuration.

[kokekanon]

in cipsoft client works fine
but in otc by enabling the feature "GameSequencedPackets" g_game.enableFeature(GameSequencedPackets)
mehah/otclient@4e79004 "SPX Protocol Support (with compress)"

If cip client works, then it must be something different at otclient side or incorrect configuration.

The client is fine, the issue is with TFS ,specifically in this line (in void ProtocolGame::onRecvFirstMessage(NetworkMessage& msg)[forgottenserver/src/protocolgame.cpp]. This if statement only integrates CipSoft, not OTCR Windows.

forgottenserver/src/protocolgame.cpp

Lines 386 to 388 in 7573e41

	if (version >= 1111 && operatingSystem >= CLIENTOS_QT_LINUX && operatingSystem < CLIENTOS_OTCLIENT_LINUX) {
	setChecksumMode(CHECKSUM_SEQUENCE);
	}

@kojimhojo tries to delete that if and it will work with g_game.enableFeature(GameSequencedPackets)

-	// Change packet verifying mode for QT clients
-	if (version >= 1111 && operatingSystem >= CLIENTOS_QT_LINUX && operatingSystem < CLIENTOS_OTCLIENT_LINUX) {
-		setChecksumMode(CHECKSUM_SEQUENCE);
-	}
+
+	setChecksumMode(CHECKSUM_SEQUENCE);
+

I confirm that it works in OTCR

---

example : player open higscore module

Server
packet size before: 4360
packet size after: 1734

Client

WARNING: raw: 4360
WARNING: descompression: 1734

floor

[nekiro]

I assume change works on both clients then.

[kojimhojo]

thanks.
i test it and works
ty

[ArturKnopik]

Tested on Cipsoft client, it's working.

This changes require update in wiki about new zlib dependency.

[ArturKnopik]

Require update in wiki about new zlib dependency.