Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor database: Extracted into tfs::db namespace #4858

Closed
wants to merge 6 commits into from

Conversation

ramon-bernardo
Copy link
Contributor

@ramon-bernardo ramon-bernardo commented Nov 25, 2024

Pull Request Prelude

Changes Proposed

  • Nothing complicated here; Database has been moved to tfs::db.

See

  • The Database singleton has been removed from DatabaseTasks. The system now uses the tfs::db namespace for managing the db, maintaining a single connection (which could potentially have drawbacks).

startupErrorMessage("Failed to connect to database.");
return;
}

std::cout << " MySQL " << Database::getClientVersion() << std::endl;
std::cout << " MySQL " << tfs::db::client_version() << std::endl;

Check warning

Code scanning / CodeQL

Potential exposure of sensitive system data to an unauthorized control sphere Medium

This operation potentially exposes sensitive system data from
*call to mysql_get_client_info
.
src/iologindata.cpp Fixed Show fixed Hide fixed
src/iologindata.cpp Fixed Show fixed Hide fixed
src/iologindata.cpp Fixed Show fixed Hide fixed
src/iologindata.cpp Fixed Show fixed Hide fixed
src/iologindata.cpp Fixed Show fixed Hide fixed
src/iologindata.cpp Fixed Show fixed Hide fixed
src/iologindata.cpp Fixed Show fixed Hide fixed
src/iologindata.cpp Fixed Show fixed Hide fixed
src/iologindata.cpp Fixed Show fixed Hide fixed
src/iologindata.cpp Fixed Show fixed Hide fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant