Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reload XML files from lua #4844

Merged
merged 2 commits into from
Nov 24, 2024

Conversation

ramon-bernardo
Copy link
Contributor

@ramon-bernardo ramon-bernardo commented Nov 19, 2024

Pull Request Prelude

Fix the problem with XML reloading via Lua; when a reload occurred, the Lua state was reset, but the XML file data was not reloaded correctly.

Changes Proposed

  • It no longer loads during the start event but instead when the Lua files are loaded
  • Move it to a separate folder in data/scripts/xml.

On reload

image

@ramon-bernardo
Copy link
Contributor Author

The other alternative would be to create a new global event for handling server reloads. However, some points to consider are when to trigger it: only when reloading scripts? actions? ...

@ghost ghost requested review from ranisalt, nekiro and MillhioreBT November 24, 2024 00:52
@ranisalt ranisalt merged commit 2aab267 into otland:master Nov 24, 2024
5 checks passed
@ramon-bernardo ramon-bernardo deleted the fix-xml-reload-altern-2 branch November 24, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants