Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct misuses of __has_cpp_attribute #4812

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/tools.h
Original file line number Diff line number Diff line change
Expand Up @@ -77,18 +77,17 @@ const std::vector<Direction>& getShuffleDirections();

namespace tfs {

#if __has_cpp_attribute(__cpp_lib_to_underlying)
#ifdef __cpp_lib_to_underlying

template <class T>
using std::to_underlying<T>;
using std::to_underlying;

#else

inline constexpr auto to_underlying(auto e) noexcept { return static_cast<std::underlying_type_t<decltype(e)>>(e); }
constexpr auto to_underlying(auto e) noexcept { return static_cast<std::underlying_type_t<decltype(e)>>(e); }

#endif

#if __has_cpp_attribute(__cpp_lib_unreachable)
#ifdef __cpp_lib_unreachable
CaseyCarter marked this conversation as resolved.
Show resolved Hide resolved

using std::unreachable;

Expand Down