Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send 0/1 as value in quest completion check #4563

Merged
1 commit merged into from
Nov 16, 2023

Conversation

rookgaard
Copy link
Contributor

@rookgaard rookgaard commented Nov 16, 2023

Pull Request Prelude

Changes Proposed

We should send 0 or 1 as value instead of true/false in addByte, just like here

msg:addByte(available and 0x01 or 0x00) -- market

@ghost ghost requested review from MillhioreBT, DSpeichert, ranisalt and nekiro November 16, 2023 14:14
Copy link
Member

@ranisalt ranisalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get why Lua had to reinvent every single behavior. It's the only language I know that can't coerce booleans to 0/1 lol

@ghost ghost merged commit 36523f8 into otland:master Nov 16, 2023
4 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants