Add RankedTree #94
Open
Add RankedTree #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and might be useful later
o8ruza8o
reviewed
Apr 7, 2017
geode/structure/RankedTree_p.h
Outdated
| } | ||
| result.max_height = 1 + max(l_stats.max_height, r_stats.max_height); | ||
| GEODE_ASSERT(2*result.black_height >= result.max_height); // Should have at least every other link black | ||
| GEODE_ASSERT(result.total_size <= 1<<result.max_height); |
|
ranked tree test dumps core -- do not merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't end up using this, but it's fairly complete and might be useful later. I'm not sure if it's ready to go into master. Overhead seems high compared to flat arrays so I'm a little worried that just using O(N) operations on std::vector might outperform O(log(N)) operations on RankedTree for relatively large N. I'd need to do some benchmarking to figure out what that value is.