Skip to content
This repository has been archived by the owner on Jan 6, 2023. It is now read-only.

Commit

Permalink
Adding License checker test cases
Browse files Browse the repository at this point in the history
  • Loading branch information
besabasr committed Aug 24, 2015
1 parent ecc7c30 commit f7843fb
Showing 1 changed file with 82 additions and 0 deletions.
82 changes: 82 additions & 0 deletions tests/LAPluginTestCase.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,82 @@
#
# LAPluginTestCase.py - Test cases for License Checker plugin, part of ISA FW
#
# Copyright (c) 2015, Intel Corporation
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions are met:
#
# * Redistributions of source code must retain the above copyright notice,
# this list of conditions and the following disclaimer.
# * Redistributions in binary form must reproduce the above copyright
# notice, this list of conditions and the following disclaimer in the
# documentation and/or other materials provided with the distribution.
# * Neither the name of Intel Corporation nor the names of its contributors
# may be used to endorse or promote products derived from this software
# without specific prior written permission.
#
# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
# DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE
# FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
# CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE

import unittest
import sys
sys.path.append("../isafw")
import isafw
import shutil
import os


reportdir = "./la_plugin/output"

class TestLAPlugin(unittest.TestCase):

def setUp(self):
# cleaning up the report dir and creating it if needed
if os.path.exists(os.path.dirname(reportdir+"/internal/test")):
shutil.rmtree(reportdir)
os.makedirs(os.path.dirname(reportdir+"/internal/test"))
# fetching proxy info
proxy = ""
if "http_proxy" in os.environ:
proxy = os.environ['http_proxy']
if "https_proxy" in os.environ:
proxy = os.environ['https_proxy']
# creating ISA FW class
self.imageSecurityAnalyser = isafw.ISA(proxy, reportdir)

def test_package_with_licenses_OK(self):
pkg = isafw.ISA_package()
pkg.name = "bash"
pkg.version = "4.3"
pkg.licenses = ["Apache-1.1"]
self.imageSecurityAnalyser.process_package(pkg)
badLicExist = os.path.isfile (reportdir + "/license_report")
# if no bad licenses exist no report is created
self.assertFalse(badLicExist)

def test_package_with_licenses_NotOK(self):
pkg = isafw.ISA_package()
pkg.name = "bash"
pkg.version = "4.3"
pkg.licenses = ["BadLicense-1.1"]
self.imageSecurityAnalyser.process_package(pkg)
with open(reportdir + "/license_report", 'r') as freport:
output = freport.readline()
print(output)
# if bad licenses exist a report listing them is created
self.assertEqual(output,
"bash: BadLicense-1.1\n",
'Output does not match')


if __name__ == '__main__':
unittest.main()

7 comments on commit f7843fb

@besabasr
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding License Checker test case file containing two test cases total

@ereshetova
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two small comments:

  • Please also add this test set into the TestSuiteISAFW.py (so that it can be run inside a full test suite also):

suite = unittest.TestLoader().loadTestsFromTestCase(TestLAPlugin)
unittest.TextTestRunner(verbosity=2).run(suite)

  • Please also correct the spacing on lines 59, 62, 63, 69-74. Otherwise it looks a bit jumping and unorganized.

@ereshetova
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the first one to work you also need to add this line to TestSuiteISAFW.py:

from LAPluginTestCase import *

@besabasr
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be the editor I am using because when I save the file is not displayed like this. I will try another one.

@ereshetova
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For any editor you might want to check the option to substitute tabs with spaces or only use spaces.

@johnwhiteman
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spaces always preferred when starting from scratch.

https://www.python.org/dev/peps/pep-0008/#tabs-or-spaces

@besabasr
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the problems and uploaded the code to the new repo, thank you for your review and help

Please sign in to comment.