workflow/docs: Fix deployments #3305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A couple fixes to make PRs and non-PRs work correctly: * In a conditional expression, `true` or `false` are returned unless you terminate both sides in a ternary. That was causing 2 strings to be suffixed with `false` instead of an empty string. * For a PR, we do actually want to cancel in progress runs since there's no danger of breaking an in progress deployment. * For PRs, just use the same `github-pages-pr` name for the artifact. The important part is that it's not called `github-pages` where an in progress deployment could pick it up. Otherwise it can use the same name all the time.
cgwalters
approved these changes
Sep 15, 2024
|
Nice! |
|
That failed one last time on push because Pages was still setup to deploy from the gh-pages branch. I changed the settings to deploy from GitHub Actions, and then triggered a manual run, which succeeded. This all appears to be working again and we should delete the |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple fixes to make PRs and non-PRs work correctly:
trueorfalseare returned unless you terminate both sides in a ternary. That was causing 2 strings to be suffixed withfalseinstead of an empty string.github-pages-prname for the artifact. The important part is that it's not calledgithub-pageswhere an in progress deployment could pick it up. Otherwise it can use the same name all the time.I've tested this now in my repo in all 3 triggers:
Pages deployed successfully at https://dbnicholson.github.io/ostree/.