lib/traverse: Fix minor memory leak #3287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericcurtin
approved these changes
Aug 20, 2024
I was trying to check something with `-fsanitize=address` and it warned about this memory leak. It's...subtle, basically we were leaking when the same commit was added to the hash table. But unfortunately fixing that then complicates ownership over the return value; what we really want to use here is `g_hash_table_steal_all_keys` but RHEL 9.4 is still rocking `glib2-2.68.4` so we can't use it. (Rust would mean we wouldn't have leaked anything here in the first place...) Signed-off-by: Colin Walters <[email protected]>
cgwalters
force-pushed
the
fix-memleak
branch
from
090c654
to
bd5b4ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to check something with
-fsanitize=addressand it warned about this memory leak. It's...subtle, basically we were leaking when the same commit was added to the hash table.But unfortunately fixing that then complicates ownership over the return value; what we really want to use here is
g_hash_table_steal_all_keysbut RHEL 9.4 is still rockingglib2-2.68.4so we can't use it.(Rust would mean we wouldn't have leaked anything here in the
first place...)